marsbar:
I have now made and tested these changes on my miniBB set-up. I share with you the exact lines below, in case they save you time.
Thank you very much! This will definitely save my time.
I have revised part of issues for today, a few remarks below:
marsbar:
All my changes keep the existing CSS classes, so nothing looks different.
Actually, it looks different. <label> is inline element by default, and CSS'
padding doesn't work with it. In /css/default.css there should be added:
label{
display: inline-block;
}
Then the changes would look similarly as with H1s.
marsbar:
Small HTML error: after the toolbar's inner table, ]td is not closed before tr closes.
Good point — strange none of HTML validators I'm using showed that. Thanks!
2. That's not correct addition. In the
main_post_area template, nothing should be added, because
{$mainPostForm} could be different regarding if the topic is closed or not (and some other conditions). If you add the code like suggested, it will generate duplicated "Your Reply" heading amongst the code provided in
main_post_form (p.1). In result, my version of the code for p.1 (
main_post_form) is:
<tr><td class="caption3"><label id="newreply" class="headingTitle vmTP vmBT">{$l_messageABC}</label> {$backToPostLink}</td></tr>
"id" works with <label>, and so does work the #newreply anchor in the URL field.
3. The same as above — if the code suggested is added, it will show duplicated content generated from
main_post_form. However <label> addition from the
main_post_form already takes care about the editing area. Then why would H1 header presented on this form? It's not a structured page. I'm not sure if a care should be taken on each of such forms, specifying H1 — they are A LOT, also present in the Admin panel and many other add-ons.
So,
is there obligation for H1 on each and every page even if it's not a structured content?
4. I accept all changes mentioned here, with addition that <label> could include
id="newtopic" as in p.1 above.
5. Accepted. As well, this form doesn't have H1 tags — I suppose it's still OK?
6.
marsbar:
With one h1 in each page template, the logo in main_header.html should no longer be an h1
Agree to this, and I'll change it to <span> in default package.
marsbar:
— main_forums.html, first line:
It should be enclosed in a table for being properly aligned:
<table class="tbTransparentmb"><tr><td><h1 class="headingTitle">{$sitename}</h1></td></tr></table>
marsbar:
main_last_discussions.html:
"Recent discussions" h1 -> h2
That's, and above, fine for the old-style layout; however for the current (modern) style I won't change anything so far;
Recent Messages will stay as the currently the only one heading present.
...
9. I'll change more codes in this template; but overall, the H1
will be present, agree to this.
10.
marsbar:
New topic preview has the topic title as h1; reply preview has no heading. A heading on both would be better
No PHP changes are required for this. `<html lang="en">` is added to the top section of
main_preview.html, and the <table> could be extended with a header like:
<tr><td><h1 class="headingTitle vmBT">{$l_preview}</h1></td></tr>
and
$topicTitle becomes like for example:
<span class="headingTitle vmTP" style="text-shadow:none">{$topicTitle2}</span>
-----
I already updated miniBB forums here with these changes, you can check them out.
As for the search forms, I'll work out them more deeper tomorrow or a bit later, this requires more "diving-in".
Thanks so far!