miniBB ® miniBB®
miniBB Support Forums
 | Forums | Register | Reply | Search | Statistics | Manual |
Bugs miniBB Support Forums / Bugs /   

addon_pfchecker_options.php - line 13 should be commented out?

Author jtalk
Registered
#1 | Posted: 31 Jan 2015 06:54 
LINE 12: $avatarsEnabled=FALSE; //if avatars are enabled, the script will try to display user's avatar
LINE 13: $avatarDbField=$dbUserSheme['user_custom1'][1]; // field which stores avatar's value - de-comment if you set the above option to TRUE

should this not be commented out by default as it says it should be?

Author Jaime
Registered
#2 | Posted: 31 Jan 2015 08:29 
You're right jtalk. But line 12 and 13? I think that line 17 and 20 with // should start ... as the line 23 (Default).

But everyone will still read the file before install? ;-)

Author Paul
Lead Developer
#3 | Posted: 31 Jan 2015 22:16 
jtalk
You're right in terms there's a confusion in the description of settings :) obviously, they are just left from the earlier versions of this add-on, when $avatarsEnabled and similar options were not introduced. Now it's not truly important, if $avatarDbField option or similar is commented or not - it won't be included in the working module anyway.

However it may be important, when 'user_custom' fields could be cut off from the default version. In that case, the LINE 13 you mention or similar should be truly commented, because the script may produce 'Warning' message regarding non-declared variable.

For now, I've just changed the comment - because this add-on comes mostly for default version, and default fields could be available. In the case of 3rd party integration, you shouldn't use this add-on at all - because 3rd party module should handle all profiles registration, their verifying etc., and not miniBB.

Bugs miniBB Support Forums / Bugs / addon_pfchecker_options.php - line 13 should be commented out? Top

Your Reply Click this icon to move up to the quoted message

 Short link for this topic:

 ?
Only registered users are allowed to post here. Please, enter your username/password details upon posting a message, or register first.


Before posting, make sure your message is compliant with our forum posting rules. If not, it may be locked or deleted with no explanation.
 
miniBB Support Forums Powered by Forum Software miniBB ® Features  Requirements  Demo  Download  Showcase  Gallery of Arts
Compiler  Premium Extensions  Premium Support  License  Contacts
Try the Captcha add-on: protect your miniBB-forums from the automated spam and flood.
Captcha Addon for miniBB