testing urls with )

On my forums, if I enter a url and directly a ) after it, it recognizes the ) as a part of the url.

Now it test it here with your newest version:

(http://www.test.de)

Seems that this bug (?) is also there in your newest version....

How can I prevent that?

You can prevent it no adding brackets :)

You say it so easy... but the problem is, that users in my forums often write something and add an url in brackets ...

The problem is, that users don't make a blank after the url!

Example:

"bla bla bla... I read something about this and that (you can read more about it here: http://www.externalurl.de) "

andreasm
it's not a bug cause some urls can contain brakets :)
how do you want to fix it? add spaces before ) ?


if so try this, in bb_func_txt change:


$patterns=array("#(^|[ \n])(https|http|ftp)://([0-9a-zA-Z$-_.+!*'(),&=\#~]+)#i", "#(^|[ \n])ftp\.([0-9a-zA-Z$-_.+!*'(),&=~]+)#i", "#(^|[ \n])www\.([0-9a-zA-Z$-_.+!*'(),&=~\#]+)#i");
$replacements=array('\\1<a href="\\2://\\3" target="_blank" rel="nofollow">\\2://\\3</a>', '\\1<a href="ftp://ftp.\\2" target="_blank" rel="nofollow">ftp.\\2</a>', '\\1<a href="http://www.\\2" target="_blank" rel="nofollow">www.\\2</a>');


to:

$patterns=array("#(^|[ \n])(https|http|ftp)://([0-9a-zA-Z$-_.+!*'(,&=\#~]+)(\))?#i", "#(^|[ \n])ftp\.([0-9a-zA-Z$-_.+!*'*,&=~]+)(\))?#i", "#(^|[ \n])www\.([0-9a-zA-Z$-_.+!*'(,&=~\#]+)(\))?#i");
$replacements=array('\\1<a href="\\2://\\3" target="_blank" rel="nofollow">\\2://\\3</a>\\4', '\\1<a href="ftp://ftp.\\2" target="_blank" rel="nofollow">ftp.\\2</a>\\3', '\\1<a href="http://www.\\2" target="_blank" rel="nofollow">www.\\2</a>\\3');

but note that in case you will use this solution ) brakets won't be allowed in urls.

Oh I didn't know that urls could contain brackets... I've never seen such urls :)


Thanks for that code!

It would be the best if that pattern would detect only ) on the last position and cut that away.

Perhaps your code does this already?

I can't read that code, it's too complicated for me :)

andreasm
the code above should do it . It won't add ) to the url string.. it will leave the ) if detected at the end of the url.

I think, it would be a better solution, if you add ')"' at the very bottom of bb_func_txt.php where it lists:

$text=str_replace(array('."', ',"', '-"', ':"', ';"'), '"', $text);

so it should be:

$text=str_replace(array('."', ',"', '-"', ':"', ';"', ')"'), '"', $text);

it will remove bracket from URL itself, but leave it in link.

It's the only efficient solution we could arrange in the next release.

But in general, the simpliest way is to separate URLs from any syntax text parts. It's a good manner of writing - you never lose the data.